CLAUDE.md: prescribe make check as pre-push gate#15
Merged
Conversation
Two changes: 1. Add a Workflow bullet making `make check` the canonical pre-push gate and call out the basedpyright/pyright gotcha. The work-4byx PR's CI failed on 8 errors that local `pyright src/` reported as clean — basedpyright is stricter (reportUnknownVariableType, reportUnusedFunction, etc.) and is what CI actually runs. Running `pyright` locally is a false-positive green. 2. Update the live-smoke example from `flight fare` (deprecated) to `flight search` (the new canonical command after work-0txq).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small updates to `CLAUDE.md` after the work-4byx/4uls/ixhv merge dance:
Add a `Pre-push gate` bullet prescribing `make check` and explicitly calling out that vanilla `pyright` is NOT the same as `basedpyright`. The work-4byx PR's CI failed with 8 errors that local `pyright src/` had reported clean — `basedpyright` (which CI runs) catches a stricter set including `reportUnknownVariableType` and `reportUnusedFunction`. Running `pyright` locally is a false-positive green.
Update the live-smoke example from `flight fare` (now deprecated) to `flight search` (the canonical command after work-0txq).
Pure docs / memory update — no code behavior change.
Why this is worth a CLAUDE.md edit and not just a memory file
It's a workflow rule (gates pre-push behavior), so it belongs in the always-loaded file rather than the on-demand `docs/memories/` set.